[#741] add support for pull requests



Detailed description

Pull requests (à la Github) are really good for code review and for accepting external contributions.

a feature "pull request" on Git repositories would be great.

General Information
Submitted by:
Martin Monperrus
Date Submitted: 2014-10-16 12:04
Last Modified by: Nobody
Last Modified: 2017-11-02 20:00
Permalink: https://fusionforge.org/tracker/a_follow.php/741
Internal Fields
Data Type: Feature requests
Assigned to: Nobody (None)
State: Open
Priority: 1
Extra Fields
Target release:
Follow-up tabs
Message  ↓
Date: 2015-04-24 12:17
Sender: Olivier Berger

Martin, we're considering this feature, as it is commonly asked by users, but there's currently no one working actively on it.

If anyone wants to sponsor such development, it would of course help speed up progress ;-)

Date: 2014-10-24 11:53
Sender: Sylvain Beucler

Currently we're focusing on improving reactivity.

Date: 2014-10-21 16:56
Sender: Martin Monperrus

Thanks for your comments.

> it is also my opinion that more and more developers get used to the "pull requests" web-based workflow yes, I agree. Pull requests are very powerful to discuss commits and accept external contributions.

> there are plans to bring code review in FusionForge "code reviews" and "pull requests" are conceptually very close.

It there already a target date?

Date: 2014-10-21 15:59
Sender: Sylvain Beucler

I agree that mailing lists are a great tool to submit patches and comment on them, just like the Git project itself does. This can be used right now in FusionForge.

However, it is also my opinion that more and more developers get used to the "pull requests" web-based workflow, and that developers (especially young ones) tend to know less how to properly use a mailing list.

Currently there is no plans to plain copy github, though there are plans to bring code review in FusionForge, probably through integration with mature code review tools.

Date: 2014-10-16 12:09
Sender: Thorsten Glaser

No, they’re not. They only invite drive-by commits.

Posting patches to mailing lists, inline, where they can be properly commented and discussed, this is what truly builds communities and contributors.

github is just a popular evil.

No attached documents

No related commits.

Field Old Value Date By
priority32018-04-22 08:59
Franck Villaume
DifficultyNone2015-04-24 12:17
Olivier Berger

No relations found.