Home My Page Projects FusionForge
Summary Activity Forums Tracker Lists News SCM Files Mediawiki Hudson/Jenkins

[#538] Improve the project hierarchy plugin

Date:
2013-02-20 16:04
Priority:
3
State:
Closed
Submitted by:
Jean-Christophe Masson (jcmasson)
Assigned to:
Franck Villaume (nerville)
Resolution:
Accepted
Base branch:
master
Target Release:
5.3
Summary:
Improve the project hierarchy plugin

Detailed description
1. Display the correct projects in the widget 'project information'
2. Sort the content of the select box for the selection of the son
2. Check if the project does not already have a parent (to avoid conflict in the project tree)
3. Multiple translations into French
4. Keep the plugin enabled if the project is a template
5. Remove the plugin in the database when the project using the plugin is deleted
Message  ↓
Date: 2013-05-02 20:19
Sender: Franck Villaume

translations updated.

Date: 2013-05-01 17:28
Sender: Franck Villaume

4. ok understand what you mean.
Code merged in master.

3. still need to be merged.

Date: 2013-04-24 08:54
Sender: Jean-Christophe Masson

4. We don't understand exactly what you mean. The purpose of our patch is to take into account the configuration. From our point of view, the code at line 2412 takes into account the use of the plugin but not the configuration used by the plugin, configuration found in the table "plugin_projects_hierarchy".

Date: 2013-04-23 19:45
Sender: Franck Villaume

2bis has been fully merged in Branch_5_2.
In master, there is also an enhancement on this topic to avoid the situation.

1. merged in Branch_5_2.

Date: 2013-04-23 18:20
Sender: Franck Villaume

thanks for the patch
(by the way, it would easier for the community if you provide the version of fusionforge you patched, i'm just guessing you're patching branch_5_2)

4. actually the code in Group.class.php does already the job.
take a look at line 2412 in master.
I tested and it works like expected. I wont merge your code.

3. still need to be merged.
2bis. still to be fully merged

Date: 2013-04-18 10:00
Sender: Jean-Christophe Masson

Here is a new patch taking into consideration your comments for points 4 and 5

Date: 2013-04-17 13:07
Sender: Franck Villaume

4. need to check if the template does use the plugin before activate it by default.
5. not needed. check is done in the delegated function.

Date: 2013-04-17 09:58
Sender: Jean-Christophe Masson

4 At project creation with a template,the purpose is to initialize the configuration of the plugin
5 We just added the control on the use of the plugin like the other implementations.
Example in MantisBTPlugin.class.php
if ($group->usesPlugin($this->name)) {
if ($this->isProjectMantisCreated($group_id)) {
if ($this->removeProjectMantis($group_id)) {
$returned = true;
}
} else {
$returned = true;
}
}

Date: 2013-04-14 17:45
Sender: Franck Villaume

status :
1 is fixed
2 is fixed
2bis is almost fixed
3 need to be merged
4 not sure what you want here. Can you provide more informations ?
5 native code already works.

Date: 2013-02-22 10:31
Sender: Franck Villaume

I take a look at your patch.
I started to commit some part, some other need to rewritten (not the sure the clone part does what you expect).

Attachments:
Size Name Date By Download
21 KiBimprove_hierarchy_plugin v2.patch2013-04-18 10:00jcmassonimprove_hierarchy_plugin v2.patch
21 KiBimprove_hierarchy_plugin.patch2013-02-20 16:04jcmassonimprove_hierarchy_plugin.patch
Field Old Value Date By
status_idOpen2013-05-02 20:20nerville
close_dateNone2013-05-02 20:20nerville
ResolutionNone2013-05-02 20:19nerville
Base branchNone2013-04-25 13:25nerville
ResolutionAwaiting Response2013-04-23 18:27nerville
File Added322: improve_hierarchy_plugin v2.patch2013-04-18 10:00jcmasson
Target branch5.2.12013-04-14 17:45nerville
ResolutionNone2013-04-14 17:45nerville
Target branchNone2013-02-23 11:25nerville
assigned_tonone2013-02-22 10:31nerville
File Added307: improve_hierarchy_plugin.patch2013-02-20 16:04jcmasson