[#617] SCM: impossible to make public repos created as private

Description

Summary:

Detailed description

Ever since that major security fix, we have the problem that plugins/scmsvn/common/SVNPlugin.class.php has…

if ($project->enableAnonSCM()) {
                                        system ("chmod -R g+wX,o+rX-w $repo") ;
                                } else {
                                        system ("chmod -R g+wX,o-rwx $repo") ;
                                }

… only in the “create” case, and that later changes only do:

if ($project->enableAnonSCM()) {
                                system ("chmod g+wX,o+rX-w $repo") ;
                        } else {
                                system ("chmod g+wX,o-rwx $repo") ;
                        }

That is, without the -R.

I move that the chmod inside the 「if (!is_dir ($repo) || !is_file ("$repo/format"))」 block be changed to always enable o+rX-w, and only the top-level directory shall be used to switch repos between public and private. We will, of course, need appropriate update code in a postinst to convert already-done repositories.

I noticed this in scmsvn and have not looked at the other scm* plugins for whether they exhibit this problem too.

Ever since that major security fix, we have the problem that plugins/scmsvn/common/SVNPlugin.class.php has…

                            if ($project-&gt;enableAnonSCM()) {
                                    system (&quot;chmod -R g+wX,o+rX-w $repo&quot;) ;
                            } else {
                                    system (&quot;chmod -R g+wX,o-rwx $repo&quot;) ;
                            }

… only in the “create” case, and that later changes only do:

                    if ($project-&gt;enableAnonSCM()) {
                            system (&quot;chmod g+wX,o+rX-w $repo&quot;) ;
                    } else {
                            system (&quot;chmod g+wX,o-rwx $repo&quot;) ;
                    }

That is, without the -R.

I move that the chmod inside the 「if (!isdir ($repo) || !isfile ("$repo/format"))」 block be changed to always enable o+rX-w, and only the top-level directory shall be used to switch repos between public and private. We will, of course, need appropriate update code in a postinst to convert already-done repositories.

I noticed this in scmsvn and have not looked at the other scm* plugins for whether they exhibit this problem too.

General Information

Submitted by:	Thorsten Glaser
Date Submitted:	2014-01-09 14:54
Last Modified by:	Nobody
Last Modified:	2017-11-02 20:00
Date Closed:	2015-05-22 12:47
Permalink:	https://fusionforge.org/tracker/a_follow.php/617

Internal Fields

Data Type:	Bugs
Assigned to:	Nobody (None)
State:	Closed
Priority:	4

Follow-up tabs

Comments (4)
Attachments (1)
Commits
Changes (6)
Relations

Message
Date: 2015-05-22 12:47 Sender: Sylvain Beucler The migration script for 6.0 reset permissions, and 6.0 will only modify the top-level directory. Fixed :)
Date: 2014-02-09 16:04 Sender: Franck Villaume I unset target release since this bug is not yet fixed.
Date: 2014-01-09 15:14 Sender: Thorsten Glaser Indeed, but this does not apply any more. Basically, what you wanted for speedup has already been applied because of security. I wanted to have this tracked so we can all think about how to best fix this without impeding security again. I’ve attached a patch as basis for discussion.
Date: 2014-01-09 15:07 Sender: Julien HEYMAN Hi, I have submit a similar patch for svn and cvs on 5.1.1 : https://fusionforge.org/tracker/index.php?func=detail&aid=460&group_id=6&atid=107

Attachments:

Size	Name	Date	By	Download
892 bytes	suggest-patch.txt	2014-01-09 15:14	Thorsten Glaser	suggest-patch.txt

No related commits.

Field	Old Value	Date	By
Resolution	Accepted As Bug	2015-05-22 12:48	Sylvain Beucler
status_id	Open	2015-05-22 12:47	Sylvain Beucler
close_date	None	2015-05-22 12:47	Sylvain Beucler
Target Release	None	2015-05-22 12:47	Sylvain Beucler
Target Release	5.1.3	2014-02-09 16:04	Franck Villaume
File Added	391: suggest-patch.txt	2014-01-09 15:14	Thorsten Glaser

No relations found.